Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli serde skip deserialize for primary key option #1186

Merged

Conversation

tsar-boomba
Copy link
Contributor

PR Info

Continuation of #846. The contributor couldn't finish it so I did.

Closes

New Features

  • Add --skip-primary-key-deserialization flag for cli
  • Add tests for the new flag

@tsar-boomba tsar-boomba changed the title Cli serde deserialize Cli serde skip deserialize for primary key option Nov 3, 2022
@billy1624 billy1624 changed the base branch from master to cli-serde-deserialize December 19, 2022 09:38
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tsar-boomba, sorry for the delay. Looks good to me. I'll merge this into a local branch where I'd like to refactor some lines before it goes into master branch.

#1318

Thanks @Witcher01 again for the initial contributions

@billy1624 billy1624 merged commit 27bd044 into SeaQL:cli-serde-deserialize Dec 19, 2022
@tsar-boomba
Copy link
Contributor Author

Glad to be able to improve this great project! 😁

@billy1624
Copy link
Member

Thanks for the contributions and the big support!! :)

billy1624 added a commit that referenced this pull request Dec 19, 2022
* Cli serde skip deserialize for primary key option (#1186)

* Add CLI option to skip primary keys with serde

Implements: #841

* Codegen: fix tests

* complete skip_deserialize cli feature

* run fmt

* fix tests

Co-authored-by: witcher <[email protected]>

* [cli] should be `#[serde(skip_deserializing)]`

* [CLI] code refactor

* [cli] rename

Co-authored-by: Isaiah Gamble <[email protected]>
Co-authored-by: witcher <[email protected]>
@tsar-boomba tsar-boomba deleted the cli-serde-deserialize branch December 19, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sea-orm-cli flag to skip deserialization of primary keys for entities
3 participants